Added condition of empty for concurrent dictionary #44581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @eiriktsarpalis, @jeffhandley Issue meta data
|
stephentoub
reviewed
Nov 12, 2020
...ries/System.Collections.Concurrent/src/System/Collections/Concurrent/ConcurrentDictionary.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Nov 15, 2020
...ries/System.Collections.Concurrent/src/System/Collections/Concurrent/ConcurrentDictionary.cs
Outdated
Show resolved
Hide resolved
|
@stephentoub Thank you for helping. Really appreciated. BTW, I like the dotnet runtime talk at dotnetConf2020 of yours and jkotas. 👍👍 |
Collection is already empty why to initialize it again with new emtpy tables.
Addressed PR feedback.
Comment corrected. Co-authored-by: Stephen Toub <stoub@microsoft.com>
stephentoub
force-pushed
the
empty-condition
branch
from
18b9747
to
4839621
Compare
stephentoub
approved these changes
Nov 16, 2020
|
Hi @stephentoub any problem with PR? I checked its been merged to master! But you open it again? Any problem? Please let me know if anything needed from my side! 😇 |
|
No problem. We've been having some infrastructure issues, and I closed/opened the PR to try to trigger CI to run. |
|
Ohh OK. OK. @stephentoub no worries! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the collection is already empty why to initialize it again with new empty tables.